-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] SUID/SGID Bit Set #3802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aegrah
added
OS: Linux
Rule: Tuning
tweaking or tuning an existing rule
Domain: Endpoint
backport: auto
Area: RAD
Team: TRADE
labels
Jun 19, 2024
Aegrah
requested review from
w0rk3r,
DefSecSentinel,
imays11,
Samirbous and
terrancedejesus
June 19, 2024 11:43
imays11
approved these changes
Jun 22, 2024
rules/cross-platform/privilege_escalation_setuid_setgid_bit_set_via_chmod.toml
Show resolved
Hide resolved
terrancedejesus
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tuning, LGTM ✅
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit 8d063e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Endpoint
OS: Linux
Rule: Tuning
tweaking or tuning an existing rule
Team: TRADE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converted the old Lucene rule over to EQL, and added additional coverage.
Removed some of the exclusions that were too exclusive. 36 hits last 90d in telemetry, which are all TP's. 25 hits in my own stack, which are all SUID/SGID testing.